Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add support for Double Kia-Hyundai 64/40kWh batteries #816

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Feature: Add support for Double Kia-Hyundai 64/40kWh batteries #816

merged 2 commits into from
Jan 24, 2025
+476 −1

Conversation

dalathegreat
Copy link
Owner

What

This PR implements support for running 2x Kia-Hyundai 64/40kWh batteries at the same time 🔋 🔋

Why

Feature requested by Discord member

How

Same way as other DoubleBattery implementations

mvgalen
mvgalen approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@mvgalen mvgalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I did not check the code, in general it seems ok.
  • We need to ASAP discuss on how to handle multiple batteries better. E.g. putting variables in structs so they can be an argument to battery functions.

@mvgalen mvgalen merged commit 3381f0a into main Jan 24, 2025
112 checks passed
@mvgalen mvgalen deleted the feature/double-battery-kia64 branch January 24, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvgalen mvgalen mvgalen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalathegreat @mvgalen