Bugfix: Halt only CAN sending towards battery while BMS resetting #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR makes the BMS Reset only halt CAN message sending towards battery
Why
The current implementation pauses CAN sending globally. That means that if you use a CAN based inverter + Period BMS reset, the inverter will also get starved of CAN messages while the reset is active. This is not desired, since it risks using power from battery while it is off. This new fix makes it pause only sending CAN towards battery while it is down.
Another issue was also that the original implementation only stopped ESP32.CAN , which was the first CAN interface. So it was impossible to use the feature right on setups where battery was not connected to fist CAN port
How
Moved the
isBMSResetActiveinto the datalayerdatalayer.system.status.BMS_reset_in_progress. Also simplified the code a bit.