Fix MEB max 1A issue / Add automatic precharge / Add basic OBD functionality #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split index_html string in header and footer part - Use header and footer for index html template page - Fix missing html and head tags in minified index html. - Do not use templating engine for debug and can log pages, by using index html header and footer directly in generated content.
This reverts commit 04a68fc. The commit only fixed the symptoms not the cause.
This reverts commit af05f28. The original commit only fixed the symptoms, the cause has been fixed, now we ran revert these.
…IVE upon reception of SOC from battery. - Change default state of bms_Status to INACTIVE - switch to ACTIVE upon reception of SOC from battery. - Do not change bms_mode to ACTIVE upon reception of info/warning/debug event. - Reset bms_mode to INACTIVE and CAN_battery_still_alive when resetting all events
- Fix printf end of line detection - Fix overwriting of timestamp in printf path - Add version + build date/time to log
Move logging of version/data/time to setup() to ensure it is also printed to serial.
- Add DTC request every second. - Add log entry for unknown CAN messages.
- Addition of transmit_obd_can_frame and handle_obd_frame functions - Use dump_can_frame function in comm_can.cpp as well. - Fix code formatting of dump_can_frame function
- Start polling frame earlier. - Prevent false positive on delayed can sending. - Add log message for first CAN received from battery. - Add log message for timeout of CAN reception from battery.
dalathegreat
requested changes
Jan 14, 2025
| @@ -341,10 +343,12 @@ void emulator_pause_state_transmit_can_battery() { | |||
| allowed_to_send_CAN = (!emulator_pause_CAN_send_ON || emulator_pause_status == NORMAL); | |||
|
|
|||
| if (previous_allowed_to_send_CAN && !allowed_to_send_CAN) { | |||
| logging.printf("Safety: Pausing CAN sending"); | |||
There was a problem hiding this comment.
Logging should be wrapped in #ifdef DEBUG LOG
…h to ACTIVE upon reception of SOC from battery." This reverts commit f6c73e9.
- Split bms_status (system status) to real_bms_status (bms status) - Put #ifdef DEBUG_LOG around all log calls. - Do not update bms_status (system status) directly, fire event instead from automatic precharge control - Add Battery BMS status to webserver for MEB battery type only
dalathegreat
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
This branch started out as just adding precharge control, but during development the max 1A issue was encountered. To try to diagnose it, the OBD queries were added. This PR closes #762 and #658.