Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-azure] default behavior testing #27041

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Jan 11, 2025

Summary & Motivation

This puts the default behavior, where we don't have access to the urls from the captured log context, under test.

This is to guard against regressions in default behavior w.r.t. captured logs, which we have seen previously.

How I Tested These Changes

New test

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dpeng817 dpeng817 marked this pull request as ready for review January 11, 2025 00:27
Copy link
Contributor

@mlarose mlarose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see notes

@dpeng817 dpeng817 force-pushed the dpeng817/additional_complogmngr_tests branch from c4c1fce to d6b82e8 Compare January 13, 2025 18:29
@dpeng817 dpeng817 force-pushed the dpeng817/additional_complogmngr_tests branch from d6b82e8 to ed2121b Compare January 13, 2025 18:52
@dpeng817 dpeng817 merged commit 390efce into master Jan 13, 2025
1 check passed
@dpeng817 dpeng817 deleted the dpeng817/additional_complogmngr_tests branch January 13, 2025 22:00
marijncv pushed a commit to marijncv/dagster that referenced this pull request Jan 21, 2025
## Summary & Motivation
This puts the default behavior, where we don't have access to the urls
from the captured log context, under test.

This is to guard against regressions in default behavior w.r.t. captured
logs, which we have seen previously.

## How I Tested These Changes
New test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants