Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deploy] Add ability to customize location load timeout #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[deploy] Add ability to customize location load timeout #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/utils/copy_template/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ inputs:
description: "A string of the base image name for the deployed code location image."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.10"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.11"
entrypoint: "/copy_template.sh"
7 changes: 6 additions & 1 deletion actions/utils/deploy/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,17 @@ inputs:
image_tag:
required: true
description: "The image tag to deploy."

location_load_timeout:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe deploy_timeout? The timeout it will wait for it be deployed by dagster cloud?

description: 'Timeout to wait for the code location deployed by the agent.'
required: false
default: '600'
outputs:
deployment:
description: "The Cloud deployment associated with this branch."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.10"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.11"
entrypoint: "/deploy.sh"
args:
- ${{ inputs.pr }}
2 changes: 1 addition & 1 deletion actions/utils/notify/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ inputs:

runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.10"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.11"
entrypoint: "/notify.sh"
args:
- ${{ inputs.pr }}
2 changes: 1 addition & 1 deletion actions/utils/registry_info/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ inputs:
description: "Alternative to providing organization ID. The URL of your Dagster Cloud organization."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.10"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.11"
entrypoint: "/registry_info.sh"
2 changes: 1 addition & 1 deletion actions/utils/run/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ outputs:
description: "The ID of the launched run."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.10"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.11"
entrypoint: "/run.sh"
args:
- ${{ inputs.pr }}
2 changes: 1 addition & 1 deletion src/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ if [[ -z $INPUT_PR_STATUS || "$INPUT_PR_STATUS" == "open" ]]; then
--location-file "${INPUT_LOCATION_FILE}" \
--location-name "${INPUT_LOCATION_NAME}" \
--image "${INPUT_REGISTRY}:${INPUT_IMAGE_TAG}" \
--location-load-timeout 600 \
--location-load-timeout $INPUT_LOCATION_LOAD_TIMEOUT \
--agent-heartbeat-timeout $AGENT_HEARTBEAT_TIMEOUT \
--git-url $COMMIT_URL \
--commit-hash $GITHUB_SHA
Expand Down