Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor typos #291

Merged
merged 1 commit into from
May 12, 2024
Merged

Fix some minor typos #291

merged 1 commit into from
May 12, 2024

Conversation

yoshikazusawa
Copy link
Contributor

I found a few small minor typos, so I'll send this patch.

@ap
Copy link
Contributor

ap commented May 11, 2024

I like this but would personally be inclined to throw in a

*_replacment_path = \&_replacement_path; # backcompat shim

just in case anyone is calling this method, despite the fact that it’s private and undocumented. Or alternatively at least call out the rename in the changelog. @xdg?

@xdg
Copy link
Contributor

xdg commented May 12, 2024

I'm fine without the shim. Thank you for the PR.

@xdg xdg merged commit a6c8eb8 into dagolden:master May 12, 2024
16 checks passed
@yoshikazusawa
Copy link
Contributor Author

@ap Thank you for your suggestion!
@xdg Thank you!

@yoshikazusawa yoshikazusawa deleted the fix-minor-typos branch May 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants