Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propogate errors from custom collection packages #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nfg
Copy link

@nfg nfg commented Jul 11, 2016

Hello!

I was playing around with Meerkat, and couldn't figure out why my custom collection class was being ignored. It turns out I was doing something dumb with Moose (I had a builder and a default for an attribute, oops). Anyway, this PR will make Meerkat screech errors if a custom collection class exists but is broken.

Cheers!

If the package isn't found, use default.
If the package is found but has errors, throw the error.
@coveralls
Copy link

coveralls commented Jul 11, 2016

Coverage Status

Coverage remained the same at 80.0% when pulling 71c5150 on nfg:feature-collection_class_errors into c8e8e71 on dagolden:master.

@xdg
Copy link
Contributor

xdg commented Jul 13, 2016

Thanks! I'm way behind on my PR reviews, but I hope to get to it soon.

@nfg
Copy link
Author

nfg commented Jul 14, 2016

No worries. Cheers. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants