-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example | Updated value for app set #72
Open
dag-andersen
wants to merge
5
commits into
main
Choose a base branch
from
helm-example-app-set
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+144
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argo CD Diff PreviewSummary: {base => target}/my-app-set-dev | 8 ++++----
{base => target}/my-app-set-prod | 8 ++++----
{base => target}/my-app-set-staging | 8 ++++----
3 files changed, 12 insertions(+), 12 deletions(-) Diff:diff --git base/my-app-set-dev target/my-app-set-dev
index 32f9556..ec75b16 100644
--- base/my-app-set-dev
+++ target/my-app-set-dev
@@ -2,21 +2,21 @@
apiVersion: v1
kind: Service
metadata:
labels:
app.kubernetes.io/instance: my-app-set-dev
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-dev
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
spec:
ports:
- name: http
port: 80
protocol: TCP
targetPort: http
selector:
app.kubernetes.io/instance: my-app-set-dev
app.kubernetes.io/name: myApp
@@ -27,35 +27,35 @@ apiVersion: v1
automountServiceAccountToken: true
kind: ServiceAccount
metadata:
labels:
app.kubernetes.io/instance: my-app-set-dev
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-dev
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
---
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/instance: my-app-set-dev
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-dev
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/instance: my-app-set-dev
app.kubernetes.io/name: myApp
template:
metadata:
labels:
@@ -77,12 +77,12 @@ spec:
- containerPort: 80
name: http
protocol: TCP
readinessProbe:
httpGet:
path: /
port: http
resources: {}
securityContext: {}
securityContext: {}
- serviceAccountName: super-app-name
+ serviceAccountName: new-app-name
diff --git base/my-app-set-prod target/my-app-set-prod
index 642d80d..96d3d16 100644
--- base/my-app-set-prod
+++ target/my-app-set-prod
@@ -2,21 +2,21 @@
apiVersion: v1
kind: Service
metadata:
labels:
app.kubernetes.io/instance: my-app-set-prod
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-prod
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
spec:
ports:
- name: http
port: 80
protocol: TCP
targetPort: http
selector:
app.kubernetes.io/instance: my-app-set-prod
app.kubernetes.io/name: myApp
@@ -27,35 +27,35 @@ apiVersion: v1
automountServiceAccountToken: true
kind: ServiceAccount
metadata:
labels:
app.kubernetes.io/instance: my-app-set-prod
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-prod
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
---
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/instance: my-app-set-prod
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-prod
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/instance: my-app-set-prod
app.kubernetes.io/name: myApp
template:
metadata:
labels:
@@ -77,12 +77,12 @@ spec:
- containerPort: 80
name: http
protocol: TCP
readinessProbe:
httpGet:
path: /
port: http
resources: {}
securityContext: {}
securityContext: {}
- serviceAccountName: super-app-name
+ serviceAccountName: new-app-name
diff --git base/my-app-set-staging target/my-app-set-staging
index 90f3421..a7fee1c 100644
--- base/my-app-set-staging
+++ target/my-app-set-staging
@@ -2,21 +2,21 @@
apiVersion: v1
kind: Service
metadata:
labels:
app.kubernetes.io/instance: my-app-set-staging
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-staging
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
spec:
ports:
- name: http
port: 80
protocol: TCP
targetPort: http
selector:
app.kubernetes.io/instance: my-app-set-staging
app.kubernetes.io/name: myApp
@@ -27,35 +27,35 @@ apiVersion: v1
automountServiceAccountToken: true
kind: ServiceAccount
metadata:
labels:
app.kubernetes.io/instance: my-app-set-staging
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-staging
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
---
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/instance: my-app-set-staging
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: myApp
app.kubernetes.io/version: 1.16.0
argocd.argoproj.io/instance: my-app-set-staging
helm.sh/chart: myApp-0.1.0
- name: super-app-name
+ name: new-app-name
namespace: default
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/instance: my-app-set-staging
app.kubernetes.io/name: myApp
template:
metadata:
labels:
@@ -77,12 +77,12 @@ spec:
- containerPort: 80
name: http
protocol: TCP
readinessProbe:
httpGet:
path: /
port: http
resources: {}
securityContext: {}
securityContext: {}
- serviceAccountName: super-app-name
+ serviceAccountName: new-app-name |
dag-andersen
force-pushed
the
helm-example-app-set
branch
from
December 22, 2024 11:22
a25710f
to
3ae8d2a
Compare
dag-andersen
force-pushed
the
helm-example-app-set
branch
from
December 26, 2024 14:43
3ae8d2a
to
20f0fa4
Compare
* cleanup * Give apps with duplicated names a name suffix * Better logging * Print error when converting yaml to string
dag-andersen
force-pushed
the
helm-example-app-set
branch
from
January 1, 2025 13:58
20f0fa4
to
ed0e0c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.