Apply java and kotlin source formatting #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable "spotless" plugin and configure that to (1) reference the default "google-java-format style" for Java and (2) use "ktlint" for Kotlin; followed by a bulk reformat of source code (via the new "spotlessApply" gradle task).
robin-aws
requested changes
Jan 8, 2025
| @@ -3,125 +3,133 @@ | |||
| */ | |||
| package org.dafny.gradle.plugin; | |||
|
|
|||
| import static org.junit.jupiter.api.Assertions.*; | |||
There was a problem hiding this comment.
This is the only point I disagree with: I don't like star imports because new classes showing up in new versions of other dependencies can break resolution of your code, and in my experience IDEs make managing imports easy enough these days that the convenience of star imports is negligable.
Is the formatter requiring this, or just allowing it?
There was a problem hiding this comment.
Interestingly it's not needed at all (vscode shows it as a warning) so can be removed. I'll add another commit to take it out.
There was a problem hiding this comment.
To answer your question though, it's allowing it, not mandating it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable "spotless" plugin and configure that to (1) reference the default "google-java-format style" for Java and (2) use "ktlint" for Kotlin; followed by a bulk reformat of source code (via the new "spotlessApply" gradle task).