Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the code from a previous blog post #29

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Verify the code from a previous blog post #29

merged 3 commits into from
Jan 3, 2024

Conversation

atomb
Copy link
Member

@atomb atomb commented Jan 2, 2024

Verify the code included in the blog post "Clear Separation of Specification and Implementation in Dafny". It was previously missing from the check target in the Makefile.

Fixes #28.

Verification of the code from this blog post was previously missing.
@atomb atomb requested review from jtristan and alex-chew January 2, 2024 22:28
@@ -0,0 +1,15 @@
#!/usr/bin/perl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we use/need perl?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the easiest way to write this, IMO, and it's pretty reliably available everywhere. Other languages would certainly work, though.

Copy link
Member

@keyboardDrummer keyboardDrummer Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the easiest way to write this, IMO

I can't comment on that, since I'm not sure how to read this code.

I think it's best to minimize the number of programming languages used in a particular repository/project. For Dafny I think it would be better not to have any Perl in there. We already have Bash and Python as scripting languages in the main Dafny repository, so I'd recommend biasing for those, with a preference for Python since I find it more readable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced it with Bash.

@atomb atomb merged commit e876dde into main Jan 3, 2024
1 check passed
@keyboardDrummer keyboardDrummer deleted the verify-clear-spec branch January 3, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIssing automated tests for "Clear Separation of Specification and Implementation in Dafny"
3 participants