treat issue problem index out of bounds! #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfireman
requested changes
Feb 27, 2020
There was a problem hiding this comment.
Existem duas formas de lidar com esse caso:
- retornar um erro que de oportunidade do usuário diferenciar erro de lista vazia (geralmente o erro é uma constante exportada). Para um exemplo disso, olha a api de consulta do driver mongo e como eles tratam o caso de lista vazia.
- retornar a resposta em forma de lista e retornar a lista vazia
Independente, também precisa estar claro na documentação
danielfireman
requested changes
Feb 28, 2020
mgo.go
Outdated
| return nil, fmt.Errorf("there is no match with these arguments") | ||
| // ErrNoDocuments means that the filter did not match any documents in the collection | ||
| if err == mongo.ErrNoDocuments { | ||
| return nil, err |
There was a problem hiding this comment.
Por favor não retorne um elemento de outro pacote que você está abstraindo do usuário. Fazendo isso você está expondo um detalhe de implementação: a forma como seu dado é armazenado.
É super simples criar uma constante dentro do seu próprio pacote e retornar ela
There was a problem hiding this comment.
Entendi, vou ter mais cuidado a partir de agora.
danielfireman
approved these changes
Feb 28, 2020
| func (c *DBClient) GetDataForSecondScreen(month int, year int, agency string) (*AgencyMonthlyInfo, error) { | ||
| c.Collection(c.monthlyInfoCol) | ||
| resultMonthly, err := c.col.Find(context.TODO(), bson.D{{Key: "aid", Value: agency}, {Key: "year", Value: year}, {Key: "month", Value: month}}) | ||
| var resultMonthly AgencyMonthlyInfo | ||
| err := c.col.FindOne(context.TODO(), bson.D{{Key: "aid", Value: agency}, {Key: "year", Value: year}, {Key: "month", Value: month}}).Decode(&resultMonthly) |
There was a problem hiding this comment.
Suggested change
| err := c.col.FindOne(context.TODO(), bson.D{{Key: "aid", Value: agency}, {Key: "year", Value: year}, {Key: "month", Value: month}}).Decode(&resultMonthly) | |
| err := c.col.FindOne(context.TODO(), bson.D{ | |
| {Key: "aid", Value: agency}, | |
| {Key: "year", Value: year}, | |
| {Key: "month", Value: month} | |
| }).Decode(&resultMonthly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9