Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-basic-ui): hydration mismatch warning #436

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix(plugin-basic-ui): hydration mismatch warning #436

merged 2 commits into from
Jan 16, 2024

Conversation

tonyfromundefined
Copy link
Member

@tonyfromundefined tonyfromundefined commented Jan 15, 2024 •
edited
Loading

  • Fix hydration mismatch warning by using useMounted() hook
  • In server environment, do not render the data-stackflow-activity-id dataset field

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Jan 16, 2024 3:26am

orionmiz
orionmiz approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@orionmiz orionmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tonyfromundefined tonyfromundefined merged commit d4e86c5 into main Jan 16, 2024
4 checks passed
@tonyfromundefined tonyfromundefined deleted the fix-basic-ui-hydration-warning branch January 16, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orionmiz orionmiz orionmiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyfromundefined @orionmiz