Update main.cpp #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added image processing by Zaycev D.
Fix process_image method by Zaycev D.A
kalaider
requested changes
Dec 8, 2019
src/zmq/zmq-source/main.cpp
Outdated
Comment on lines
283
to
296
| cv::GaussianBlur(in_out, in_out, { 51, 51 }, 0); | ||
| int lowThreshold = 200; | ||
| int ratio = 10; | ||
| int kernel_size = 5; | ||
| cv::Mat frame_open_CV_gray, dst; | ||
| dst.create(frame_open_CV.size(), frame_open_CV.type()); | ||
| cv::cvtColor(frame_open_CV, frame_open_CV_gray, cv::COLOR_BGR2GRAY); | ||
| cv::blur(frame_open_CV_gray, detected_edges, cv::Size(kernel_size, kernel_size)); | ||
| cv::Canny(detected_edges, detected_edges, lowThreshold, lowThreshold * ratio, kernel_size); | ||
| dst = cv::Scalar::all(0); | ||
| frame_open_CV.copyTo(dst, detected_edges); | ||
| frame_open_CV_gray.release(); | ||
| dst.release(); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Could you replace all tabs with spaces. Some viewers/editors (e.g. GitHub) render tabs with 8 spaces instead of desired 4. Visual Studio allows replacing strings matching certain regex in entire project.
| // stub image processing | ||
| void process_image(cv::Mat & in_out) | ||
| //finding boundaries | ||
| int border_image(cv::Mat& frame_open_CV, cv::Mat& detected_edges) |
| } | ||
|
|
||
| //reduction and merge | ||
| int reduction_plus_merge_image(cv::Mat& frame_open_CV, cv::Mat& detected_edges, cv::Mat& reduction_matrix) |
There was a problem hiding this comment.
First two parameters may be const.
| // stub image processing | ||
| void process_image(cv::Mat & in_out) | ||
| //finding boundaries | ||
| int border_image(cv::Mat& frame_open_CV, cv::Mat& detected_edges) |
Destroy some bugs.
kalaider
requested changes
Dec 9, 2019
| border_image(frame_open_CV, detected_edges); | ||
| reduction_plus_merge_image(frame_open_CV, detected_edges, reduction_matrix); | ||
| reduction_matrix.copyTo(in_out); | ||
| in_out = cv::Mat(); | ||
| frame_open_CV.release(); |
There was a problem hiding this comment.
Explicit release again is redundant.
src/zmq/zmq-source/main.cpp
Outdated
Comment on lines
312
to
318
| for (int t = 0; t < 3; t++) | ||
| { | ||
| channels_frame_open_CV[0].data[i * frame_CV_width + j] = z + step_z / 2; | ||
| } | ||
| if (channels_frame_open_CV[1].data[i * frame_CV_width + j] > z&& | ||
| channels_frame_open_CV[1].data[i * frame_CV_width + j] < z + step_z) | ||
| { | ||
| channels_frame_open_CV[1].data[i * frame_CV_width + j] = z + step_z / 2; | ||
| } | ||
| if (channels_frame_open_CV[2].data[i * frame_CV_width + j] > z&& | ||
| channels_frame_open_CV[2].data[i * frame_CV_width + j] < z + step_z) | ||
| { | ||
| channels_frame_open_CV[2].data[i * frame_CV_width + j] = z + step_z / 2; | ||
| if (channels_frame_open_CV[t].data[i * frame_CV_width + j] > z&& | ||
| channels_frame_open_CV[t].data[i * frame_CV_width + j] < z + step_z) | ||
| { | ||
| channels_frame_open_CV[t].data[i * frame_CV_width + j] = z + step_z / 2; | ||
| } |
There was a problem hiding this comment.
Please, deal with these awful tabs!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added image processing by Zaycev D.