This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
Links now rendered properly when taller than they are wide #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each link between nodes is drawn using a bezier curve from the right-hand side of the From node to the left-hand side of the To node. The stroke width of the bezier curve corresponds to the amount of flow.
If a bezier curve has a wide stroke width and slopes up or down steeply, it sweeps out too much area. Here's a picture of the problem: http://s27.postimg.org/ifhkwvddv/render_problem.png
I fixed the problem by placing a maximum on the widths of the Bezier curves. Large links are now drawn using several smaller adjacent bezier curves.
This is a breaking change in some cases: existing code setting each path's stroke width to the link's
dy
property should now use the link'sstrokeWidth
property.