Mark core Error methods as #[cold]

Basically all error handling paths are assumed to be cold and only rarely called. Convey that to the compiler by marking two of the core ones as #[cold], so that it can try and generate better code as a result. This attribute should transitively affect all call-sites. Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o · Oct 24, 2024 · d246369 · d246369
1 parent 0e769da
commit d246369
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/error.rs b/src/error.rs
@@ -433,7 +433,7 @@ pub struct Error {
 }
 
 impl Error {
-    #[inline]
+    #[cold]
     fn with_io_error<E>(kind: io::ErrorKind, error: E) -> Self
     where
         E: ToString,
@@ -482,6 +482,7 @@ impl Error {
 
     /// Layer the provided context on top of this `Error`, creating a
     /// new one in the process.
+    #[cold]
     fn layer_context(self, context: Cow<'static, Str>) -> Self {
         match context {
             Cow::Owned(context) => Self {