Skip to content

Commit

Permalink
Add TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
d-e-s-o committed Apr 14, 2024
1 parent 9a09e10 commit 5ba4b8d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/api/v2/account_activities.rs
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,8 @@ pub struct NonTradeActivityImpl<T> {
pub type_: T,
/// The date on which the activity occurred or on which the
/// transaction associated with the activity settled.
// TODO: Should probably be a `Date<Utc>`, but we should check whether
// it is actually naive (likely).
#[serde(rename = "date", deserialize_with = "datetime_from_date_str")]
pub date: DateTime<Utc>,
/// The net amount of money (positive or negative) associated with the
Expand Down
1 change: 1 addition & 0 deletions src/api/v2/order.rs
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ pub struct CreateReq {
#[derive(Clone, Debug, Default, Deserialize, Eq, PartialEq, Serialize)]
pub struct ChangeReq {
/// Number of shares to trade.
// TODO: Should this really be an `Amount`?
#[serde(rename = "qty")]
pub quantity: Option<Num>,
/// How long the order will be valid.
Expand Down
2 changes: 2 additions & 0 deletions src/data/v2/last_quotes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ impl GetReqInit {

/// A quote as returned by the /v2/stocks/quotes/latest endpoint.
// TODO: Not all fields are hooked up.
// TODO: Given that this struct is shared, consider moving it into a
// more neutral position.
#[derive(Clone, Debug, Deserialize, Eq, PartialEq)]
pub struct Quote {
/// The time stamp of this quote.
Expand Down

0 comments on commit 5ba4b8d

Please sign in to comment.