Backport PR4877 to the 3.8 branch. #4881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where setting an avatar with JMAP Contact/set on an existing vCard 4.0 card resulted in the vCard having a b-encoded PHOTO value. But PHOTO must have a data: URI value in vCard 4.0 Backported from b8a879c
elliefm
added
backport-to-3.8
|
Thanks! Labelling this with the backport-to-3.8 label and the do-not-merge label, so that a) it doesn't get forgotten, but b) doesn't accidentally land on the 3.8 branch until I'm ready for it to do so (there's some other stuff in flight at the moment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports b8a879c of #4877 to the 3.8 branch. To do so, it also backports d5ccab4.