Fix IMAP SCAN on selected mailbox crasher #4552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliefm
requested changes
Jul 25, 2023
ksmurchison
force-pushed
the
imap_scan_fix
branch
from
ddabf29
to
ba22b56
Compare
ksmurchison
force-pushed
the
imap_scan_fix
branch
from
ba22b56
to
dd3a777
Compare
|
Actually, SCAN was broken worse than just the crasher. It always returned nothing due to a logic error in the ACL test. And then it returned EXISTS, RECENT, and FLAGS responses fro every mailbox that is scanned. All issues have been fixed and tested - SCAN with/without a previously SELECTed mailbox |
rsto
approved these changes
Aug 2, 2023
Signed-off-by: Robert Stepanek <[email protected]>
|
I fixed a memory leak in the new code and pushed an update. |
elliefm
reviewed
Aug 2, 2023
Signed-off-by: Robert Stepanek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imapd.c: needs an open mailbox for index_scan(), imapd_index is released before every command is parsed, so we need to reopen the mailbox