Fix some typos #3506
Merged
Fix some typos #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliefm
approved these changes
May 28, 2021
rsto
previously requested changes
May 28, 2021
There was a problem hiding this comment.
Thanks for fixing these typos, @dilyanpalauzov
However, I do request to change the commit message. We can talk about the pros and cons of DCOs, but the commit history isn't the right place to do this. Could you please remove you arguments against DCOs from the commit?
If you would like to share your arguments, please do it on the cyrus development list where we can have a discussion.
|
At the very least, the typo in 'presense' should be fixed, or this merge request is ironically self-defeating. |
ksmurchison
approved these changes
Sep 11, 2024
ksmurchison
approved these changes
Sep 11, 2024
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Sep 24, 2024
cyrusimap#3506 IN UPSTREAM NOT IN 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.