chore: update system tests and prep for react18 harness removal/upstream merge for component testing #30614
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/update-tests-prep-react-18-ct-update
|
| Run status |
|
| Run duration | 17m 44s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29318
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.79%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
163
|
Accessibility
92.56%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
892
|
…ncies for applicable system tests. use react18 harness before removal [run ci]
AtofStryker
force-pushed
the
chore/update-tests-prep-react-18-ct-update
branch
from
04b374f
to
cbdb33a
Compare
| @@ -1789,7 +1789,7 @@ jobs: | |||
| PLATFORM: linux | |||
| machine: | |||
| # using `machine` gives us a Linux VM that can run Docker | |||
| image: ubuntu-2004:202111-02 | |||
| image: ubuntu-2004:2024.05.1 | |||
There was a problem hiding this comment.
needs to be updated since find-up update in the module-api system test is now on version 7 and cannot be installed with node 16. ubuntu-2004:202111-02 ships with node 16, as ubuntu-2004:2024.05.1 ships with node 20.13.0
| @@ -42,7 +42,7 @@ | |||
| "src/**/*.js" | |||
| ], | |||
| "engines": { | |||
| "node": ">=8" | |||
| "node": ">=18" | |||
There was a problem hiding this comment.
just a missed detail. Cypress requires node 18 and up so this is a non breaking change
| line: 26, | ||
| column: 8, | ||
| line: 19, | ||
| isPreprocessorWithTypescript: true, |
There was a problem hiding this comment.
this is needed here since we are having stack codeframe/stacktraces now transpiled from typescript 4 to 5, which is slightly different than what is expected in the javascript context
| @@ -70,6 +71,8 @@ export const verify = (title, ctx, options) => { | |||
| // code frames will show this as the 1st line | |||
| if (isCyOrigin) { | |||
| cy.get('.test-err-code-frame pre span').should('include.text', `('${title}',,function()`) | |||
| } else if (isPreprocessorWithTypescript) { | |||
There was a problem hiding this comment.
has to do with using typescript in some of these on ts version 5 vs 5, which means the transpilation is slightly different. This is related to #29614
| @@ -616,6 +625,23 @@ When Cypress detects uncaught errors originating from your test code it will aut | |||
| Cypress could not associate this error to any specific test. | |||
|
|
|||
| We dynamically generated a new test to display this failure. | |||
| Error: The following error originated from your test code, not from Cypress. | |||
There was a problem hiding this comment.
Why is this error showing up twice in the output?
There was a problem hiding this comment.
It's the update to babel-loader from from 8 to 9. We usually append the error in the stack output if we can find it, and I think the enhancement there is making it show up
There was a problem hiding this comment.
Will that look weird to the user to have it show up twice? Or is this just a system test nuance?
There was a problem hiding this comment.
I don't believe so since this is our default behavior if we can discover a message. My guess is previously there wasn't a message attached with the error and now there is, so we have something to print
Additional details
The goal of this PR is to get our system tests up to date with the latest technologies that we support. This means:
webpack/webpack-dev-serverfromv4tov5and related loaders/dependenciestypescriptfromv4tov5is most tests (except ts 4 explicit tests)reactsystem tests from16x/17xto18xand using thecypress/react18test harness as a precursor to breaking: remove support for React 16 and 17 for Cypress Component Testing. Additionally, remove thecypress/react18testing harness and merge it upstream withcypress/react#30590 (react17 system tests are removed here).package.jsonwebpack-preprocessor-awesome-typescript-loadertests as it isn't actively maintained andts-loaderis now the used loader by mostreact-app-webpack-5-unconfiguredapp and replacing withreact18-webpack-unconfiguredas it is a lot smaller and easier to maintain (not theejectedcreate-react-app)issue-25951-next-appis removed as this is tested with next versions over 13 passively. We currently support 14+module-apisnapshots needed to be updated with updatingsnap-shot-it2 major versions, so now the snapshots live in a single fileto make the system tests on webpack more deterministic, I changed the stat output to be errors only so we don't have a lot of drift when new modules or times exist in the snapshot
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?