Skip to content

Commit

Permalink
update tests / suggestions from code review [run ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
AtofStryker committed Nov 15, 2024
1 parent 34043f9 commit 90da84a
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export default function Counter2WithHooks () {

useEffect(() => {
document.title = `You clicked ${count} times`
})
}, [count])

return (
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export function Users () {

const getUsers = async () => {
const response = await axios.get('https://jsonplaceholder.cypress.io/users?_limit=3')
// JSON responses are automatically parsed.

setUsers(response.data)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export function Users () {
const getUsers = async () => {
console.log({ axiosApi })
const response = await axiosApi.get('https://jsonplaceholder.cypress.io/users?_limit=3')
// JSON responses are automatically parsed.

setUsers(response.data)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default function MouseMovement ({ onMoved }) {
clearTimeout(timer)
setTimer(undefined)
}
})
}, [])

return null
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function App () {
return () => {
clearTimeout(_timer)
}
})
}, [])

return (
<div className="App">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default function LoadingIndicator ({ isLoading, children }) {
return () => {
clearTimeout(_delayTimer)
}
})
}, [])

if (isLoading) {
if (!isPastDelay) {
Expand Down

5 comments on commit 90da84a

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 90da84a Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/linux-arm64/breaking/remove_react_16_17_merge_react18_harness_upstream-90da84a3b556a58952cc654b6a374f7dfa9b7707/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 90da84a Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/linux-x64/breaking/remove_react_16_17_merge_react18_harness_upstream-90da84a3b556a58952cc654b6a374f7dfa9b7707/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 90da84a Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/darwin-arm64/breaking/remove_react_16_17_merge_react18_harness_upstream-90da84a3b556a58952cc654b6a374f7dfa9b7707/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 90da84a Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/darwin-x64/breaking/remove_react_16_17_merge_react18_harness_upstream-90da84a3b556a58952cc654b6a374f7dfa9b7707/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 90da84a Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/win32-x64/breaking/remove_react_16_17_merge_react18_harness_upstream-90da84a3b556a58952cc654b6a374f7dfa9b7707/cypress.tgz

Please sign in to comment.