Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update angular documentation with supported versions from Cypress 14 #5983

Merged

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Nov 5, 2024

Updates Angular to the minimum version support (17.2.0) and adds migration docs

Example app updates: cypress-io/cypress-component-testing-apps#31

…ess 14 and add migration guide documentation
Copy link

cypress bot commented Nov 5, 2024

cypress-documentation    Run #80

Run Properties:  status check passed Passed #80  •  git commit a0a0561cc5: address comments from code review
Project cypress-documentation
Branch Review chore/update_angular_documentation_versioning
Run status status check passed Passed #80
Run duration 03m 48s
Commit git commit a0a0561cc5: address comments from code review
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 279
View all changes introduced in this branch ↗︎
UI Coverage  10.89%
  Untested elements 1802  
  Tested elements 3  
Accessibility  95.72%
  Failed rules  1 critical   5 serious   4 moderate   0 minor
  Failed elements 571  


With [LTS ending](https://angular.dev/reference/releases#actively-supported-versions) for Angular 16, the minimum required Angular version for component testing is now `17.2.0` in order to support [signals](/app/component-testing/angular/examples#Signals) as a first class citizen.

If for any reason an older version of Angular must be used, please download [`@cypress/angular`](https://www.npmjs.com/package/@cypress/angular) `2.x` from `npm`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@mschile mschile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Left a few small comments.

@AtofStryker
Copy link
Contributor Author

@mschile I have your comments addressed in a0a0561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants