-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update angular documentation with supported versions from Cypress 14 #5983
Merged
AtofStryker
merged 2 commits into
release/14.0.0
from
chore/update_angular_documentation_versioning
Nov 6, 2024
Merged
chore: update angular documentation with supported versions from Cypress 14 #5983
AtofStryker
merged 2 commits into
release/14.0.0
from
chore/update_angular_documentation_versioning
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess 14 and add migration guide documentation
This was
linked to
issues
Nov 5, 2024
cypress-documentation Run #80
Run Properties:
|
Project |
cypress-documentation
|
Branch Review |
chore/update_angular_documentation_versioning
|
Run status |
Passed #80
|
Run duration | 03m 48s |
Commit |
a0a0561cc5: address comments from code review
|
Committer | AtofStryker |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
279
|
View all changes introduced in this branch ↗︎ |
UI Coverage
10.89%
|
|
---|---|
Untested elements |
1802
|
Tested elements |
3
|
Accessibility
95.72%
|
|
---|---|
Failed rules |
1 critical
5 serious
4 moderate
0 minor
|
Failed elements |
571
|
Merged
3 tasks
jennifer-shehane
approved these changes
Nov 5, 2024
|
||
With [LTS ending](https://angular.dev/reference/releases#actively-supported-versions) for Angular 16, the minimum required Angular version for component testing is now `17.2.0` in order to support [signals](/app/component-testing/angular/examples#Signals) as a first class citizen. | ||
|
||
If for any reason an older version of Angular must be used, please download [`@cypress/angular`](https://www.npmjs.com/package/@cypress/angular) `2.x` from `npm`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
mschile
reviewed
Nov 6, 2024
mschile
reviewed
Nov 6, 2024
mschile
reviewed
Nov 6, 2024
mschile
reviewed
Nov 6, 2024
mschile
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Left a few small comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular to the minimum version support (17.2.0) and adds migration docs
Example app updates: cypress-io/cypress-component-testing-apps#31