build: disable default provenance attestation #1152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports resolution of
Issue
Docker Buildx v0.10.0 introduced a breaking change causing multi-architecture manifests to use
oci
instead ofdocker
imageType
formats. The release notes warn about issues with registry and runtime support. This already caused a issue in this repo (see docker-image-not-found not compatible with oci mediatype #1141). It is unknown whether allowing the manifestimageType
to change for Cypress Docker images would cause usage issues in users' environments and it would have to be considered as a breaking change for Cypress Docker.This repo is currently using Buildx v0.9.1 so this issue needs to be considered and prepared before any update to Buildx
v0.10.x
takes place:16.17.1
Change
In order to keep the current manifest schema as follows:
instead of moving to
an environment variable setting BUILDX_NO_DEFAULT_ATTESTATIONS=1, introduced in Buildx 0.10.4, is added to the
push
job of the circle.yml workflow.