Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow choosing a Node version in the run job #484

Merged

Conversation

deiga
Copy link
Contributor

@deiga deiga commented Aug 23, 2024

Addresses #475

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@deiga deiga marked this pull request as draft August 23, 2024 10:36
@deiga deiga marked this pull request as ready for review August 23, 2024 10:38
@deiga
Copy link
Contributor Author

deiga commented Sep 3, 2024

@jennifer-shehane Could you or someone else re-trigger the pipeline, since my user doesn't have permissions to the contexts in the Pipeline :)

@jennifer-shehane
Copy link
Member

@deiga Someone from our team would have to followup on publishing the changes.

@jennifer-shehane jennifer-shehane changed the title Allow choosing a Node version in the run job feat: Allow choosing a Node version in the run job Sep 3, 2024
.circleci/test-deploy.yml Outdated Show resolved Hide resolved
@deiga
Copy link
Contributor Author

deiga commented Sep 16, 2024

@mschile Thanks for fixing it! Could you trigger another run?

@deiga deiga requested a review from mschile September 16, 2024 18:43
@MikeMcC399
Copy link
Collaborator

@deiga

The example src/examples/node-version.yml from this PR has been merged into the master branch and published as release 3.4.0, however it has not been published to the website https://circleci.com/developer/orbs/orb/cypress-io/cypress#usage-node-version which still shows the non-working example:

image

I don't know how to resolve this issue. It may need help from CircleCI support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants