Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed 18.x and 20.x Node.js versions in test-deploy.yml workflow #481

Closed
MikeMcC399 opened this issue Jul 19, 2024 · 0 comments · Fixed by #483
Closed

Mixed 18.x and 20.x Node.js versions in test-deploy.yml workflow #481

MikeMcC399 opened this issue Jul 19, 2024 · 0 comments · Fixed by #483

Comments

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Jul 19, 2024

Issue

The workflow .circleci/test-deploy.yml is using mixed major versions of Node.js 18.x and 20.x (18.20.3 & 20.6.0).

install-and-persist:
executor:
name: cypress/default
node-version: "20.6.0"

docker:
- image: cypress/browsers:node-18.20.3-chrome-125.0.6422.141-1-ff-126.0.1-edge-125.0.2535.85-1

There is no guarantee that a project installed with npm under Node.js 20 will always run under Node.js 18 even though at the moment it does.

Desired

Update the workflow .circleci/test-deploy.yml to use one major version of Node.js, the current LTS version 20.15.1, or later 20.x if available (see Node.js release schedule and Download Node.js).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant