Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(deps): update angular example to version 17.3.12 #480

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Jul 19, 2024

Issue

The Angular project in examples/angular-app is currently configured to use Angular 16.2.12. This version has already transitioned out of active support and its LTS support ends in Nov 2024 (see Actively supported versions).

Additionally, as listed in Angular - Version compatibility, Angular 16.x is constrained to ^16.14.0 || ^18.10.0 which causes Node.js version inconsistencies in .circleci/test-deploy.yml, where simultaneously Node.js 20.6.0 and 18.20.3 are configured.

Compatibility

  • .circleci/test-deploy.yml currently runs in a Cypress Docker container from the cypress/browsers:node-18.20.3-chrome-125.0.6422.141-1-ff-126.0.1-edge-125.0 image.
  • Angular 17.4.x is compatible with
    • Node.js ^18.13.0 || ^20.9.0
    • TypeScript >=5.2.0 <5.5.0

Change

In examples/angular-app apply Angular Update Guide 16.0 to 17.0 to update from Angular 16.2.12 to 17.3.12

Execute

cd examples/angular-app
npx ng update @angular/core@17 @angular/cli@17

Verification

Local current browsers

On Ubuntu 22.04.4 LTS with Node.js 18.20.3

cd examples/angular-app
npm ci
npx cypress run --component
npx cypress run --component --browser chrome
npx cypress run --component --browser edge
npx cypress run --component --browser firefox
npx ng serve

In separate terminal

npx ng test
npx cypress run

Local Docker

(Only tests component tests, not E2E)

cd examples/angular-app
npm ci
docker run -it --rm -v .:/e2e -w /e2e cypress/browsers:node-18.20.3-chrome-125.0.6422.141-1-ff-126.0.1-edge-125.0.2535.85-1
npx cypress install
npx cypress run --component
npx cypress run --component --browser chrome
npx cypress run --component --browser edge
npx cypress run --component --browser firefox

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane jennifer-shehane merged commit ca49a0e into cypress-io:master Jul 24, 2024
9 of 10 checks passed
@MikeMcC399 MikeMcC399 deleted the update/angular-17 branch July 25, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants