Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Snapshot updates for R-CMD-check-dev ({"package":"gh"}) #788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: Snapshot updates for R-CMD-check-dev ({"package":"gh"}) #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions tests/testthat/_snaps/parse-news-items.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@

[
{
"description": "Improve parsing of conventional commit messages (#332).",
"type": "Features",
"description": "PLACEHOLDER https://github.com/cynkra/fledge/pull/332 (#332).",
"type": "Uncategorized",
"breaking": false,
"scope": "NA"
}
Expand All @@ -49,17 +49,42 @@
suppressMessages(extract_newsworthy_items(
"Merge pull request #18 from someone/conventional-parsing"))
Output
<error/httptest2_request>
Error in `stop_request()`:
! An unexpected request was made:
GET https://api.github.com/repos/cynkra/fledge/pulls/18
Expected mock file: api.github.com/repos/cynkra/fledge/pulls/18.*
---
Backtrace:
x
1. +-base::suppressMessages(extract_newsworthy_items("Merge pull request #18 from someone/conventional-parsing"))
2. | \-base::withCallingHandlers(...)
3. \-fledge:::extract_newsworthy_items("Merge pull request #18 from someone/conventional-parsing")
4. \-fledge:::parse_merge_commit(message) at fledge/R/parse-news-items.R:70:5
5. \-fledge:::harvest_pr_data(message) at fledge/R/parse-news-items.R:240:3
6. +-base::tryCatch(...) at fledge/R/parse-news-items.R:286:5
7. | \-base (local) tryCatchList(expr, classes, parentenv, handlers)
8. | \-base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
9. | \-base (local) doTryCatch(return(expr), name, parentenv, handler)
10. +-base::suppressMessages(gh(glue("GET /repos/{slug}/pulls/{pr_number}"))) at fledge/R/parse-news-items.R:289:9
11. | \-base::withCallingHandlers(...)
12. \-fledge:::gh(glue("GET /repos/{slug}/pulls/{pr_number}")) at fledge/R/parse-news-items.R:289:9
13. \-gh::gh(...) at fledge/R/utils-gh.R:2:3
14. \-gh:::gh_make_request(req) at gh/R/gh.R:203:3
15. \-httr2::req_perform(req, path = x$desttmp) at gh/R/gh.R:317:3
16. \-httptest2 (local) mock(req) at httr2/R/req-perform.R:83:5
17. \-httptest2:::stop_request(req)
# A tibble: 1 x 4
description type breaking scope
<chr> <chr> <lgl> <lgl>
1 Improve parsing of conventional commit messages (@someon~ Feat~ FALSE NA
1 PLACEHOLDER https://github.com/cynkra/fledge/pull/18 (#1~ Unca~ FALSE NA

# Can parse PR merge commits - linked issues

[
{
"description": "improve bump_version() (error) messages (#153, cynkra/dm#325, #328).",
"type": "Features",
"description": "PLACEHOLDER https://github.com/cynkra/fledge/pull/328 (#153, cynkra/dm#325, #328).",
"type": "Uncategorized",
"breaking": false,
"scope": "NA"
}
Expand Down