-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Leave empty line between NEWS entries #685
base: main
Are you sure you want to change the base?
Conversation
Let's keep pandoc for now, we might want to parse links or other markup later. I think that the problem here is that |
subsections_present <- (is_any_named(lines)) | ||
|
||
if (!subsections_present) { | ||
lines <- gsub("^- ", "\n- ", lines) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit of a hack... sometimes there are new lines in the messages, but we've bulleted them previously so we can recognize items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems challenging. What are we missing?
|
||
## Bug fixes | ||
|
||
- Prevent racing of requests. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want the empty paragraphs here?
I wonder if we make some lines Markdown too early. We use Pandoc, get HTML, then we shouldn't go back to Markdown before the writing stage, this way we can differentiate line breaks and actual paragraphs. |
I noticed that there should be a flexibility of main header level (are versions h1 and h2) but it is not respected for the scope of conventional commits. I'll leave this aside for a while. |
Also want to strip spaces at EOL as part of this. |
For some reason, this adds spurious newlines. @maelle: can you please take a look?
Moving forward, should we replace pandoc by something lighter-weight? We really only need to detect
/^#+/
because we assume that nobody will write unindented code blocks or similar that contain this pattern. I'm willing to live with any limitations that will bring.With pandoc, tests are running very slow too.