Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment with less resource wasting #161

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

experiment with less resource wasting #161

wants to merge 15 commits into from

Conversation

maelle
Copy link
Member

@maelle maelle commented Nov 23, 2021

Fix #135

@krlmlr I have been thinking about wasting resources cf https://www.ryanfiller.com/blog/why-my-blog-stopped-using-deploy-previews

With this workflow, to get a preview one adds the "needs-preview" label. I'd like to merge this to then try again as currently I think the PR workflow from master applies? I see the label workflow works but I am not sure it posts the URL as commit status.

@maelle maelle requested a review from krlmlr November 23, 2021 12:54
@maelle maelle marked this pull request as ready for review November 23, 2021 12:54
@maelle
Copy link
Member Author

maelle commented Nov 23, 2021

Ah I think it now really works (the regex in the pkgdown workflow was catching this branch 😅 )

@maelle
Copy link
Member Author

maelle commented Nov 23, 2021

@krlmlr I'm hoping it'd also work for forks.

@krlmlr
Copy link
Contributor

krlmlr commented Nov 23, 2021

Can we deploy automatically, but only if the documentation changes?

We're still running a huge build matrix...

@maelle
Copy link
Member Author

maelle commented Nov 24, 2021

Can we deploy automatically, but only if the documentation changes?

Do you mean pre-pkgdown building or do you mean post-pkgdown building? It's unclear to me where we'd store information on what the last deploy website and source were. 🤔

With this change we'd manually decide whether to label the PR as needs-preview so I assume less often than at each commit.

@krlmlr
Copy link
Contributor

krlmlr commented Nov 26, 2021

We'd assume that gh-pages contains the last deployed website, and deploy to Netlify only if the current state has changes? Of course this requires stable pkgdown builds, which isn't always given.

Let's put this on the backburner for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

pkgdown preview
2 participants