Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slots to Tree component #299

Closed
wants to merge 3 commits into from
Closed

Add slots to Tree component #299

wants to merge 3 commits into from

Conversation

kinow
Copy link
Member

@kinow kinow commented Nov 4, 2019

These changes partially address #145

WIP: hard/boring part done and working, which was converting each element to a JSX JS call. Now pending:

  • merge conflicts after Add families and parents to tree view query #291 (new block added for families needs to be converted to JSX too)
  • insert slots and pass them recursively to the TreeItem child component
  • implement the GScan sidebar panel using the Tree with minDepth=0 & TreeItems with slots for the top level workflow level, which do not render children nodes, instead displaying only workflow name, and summary of existing job states in the workflow

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@kinow kinow added this to the 0.2 milestone Nov 4, 2019
@kinow kinow self-assigned this Nov 4, 2019
@kinow
Copy link
Member Author

kinow commented Nov 4, 2019

image

Should have the exact same behaviour as previous version when seeing the tree view/component.

@kinow
Copy link
Member Author

kinow commented Nov 5, 2019

Not necessary, superseded by simpler GScan component in #301

@kinow kinow closed this Nov 5, 2019
@kinow kinow deleted the slotify-tree branch March 19, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant