Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color cylc logo. #266

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Color cylc logo. #266

merged 1 commit into from
Sep 25, 2019

Conversation

hjoliver
Copy link
Member

The new UI is looking pretty slick, but a bit too grey IMO. Besides @oliver-sanders latest design doc does use the color logo: #87 (comment)

The Inkscape-generated color SVG file is stored on cylc/cylc-admin; I hand-edited the file to remove all the extraneous cruft for this PR.

@kinow - two questions:

  • the UI is using inlined-SVG in Header.vue - do we need public/img/logo.svg as well?
  • if we do, should we keep the grey-scale version too? (or I could store that alongside the color one on cylc-admin, for safe-keeping).

shot

@hjoliver hjoliver added this to the 0.2 milestone Sep 25, 2019
@hjoliver hjoliver requested a review from kinow September 25, 2019 23:24
@hjoliver hjoliver self-assigned this Sep 25, 2019
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #266   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          16     16           
  Lines         226    226           
=====================================
  Misses        226    226

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29307f...c8e80c6. Read the comment docs.

@kinow
Copy link
Member

kinow commented Sep 25, 2019

the UI is using inlined-SVG in Header.vue - do we need public/img/logo.svg as well?

No, but I added that image to be used by the JupyterHub - if I remember well.

@kinow
Copy link
Member

kinow commented Sep 25, 2019

if we do, should we keep the grey-scale version too? (or I could store that alongside the color one on cylc-admin, for safe-keeping).

If we won't use the logo for JupyterHub, then we can remove both. If we will use it, then I vote to keep only the file actually used and then move it to cylc-admin as you said.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kinow
Copy link
Member

kinow commented Sep 25, 2019

One review will do, or shall we wait for @oliver-sanders to have time to look at this too @hjoliver ?

@hjoliver
Copy link
Member Author

(oh yeah, I forgot about the hub logo usage).

One review will do, since it conforms to the design drawings.

@hjoliver hjoliver merged commit 078dd2f into cylc:master Sep 25, 2019
@hjoliver hjoliver deleted the color-logo branch September 25, 2019 23:59
@kinow kinow mentioned this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants