Add host and progress information (mean elapsed time, execution time) to GraphQL query (mock and real) #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
changed the title
kinow
commented
Sep 3, 2019
oliver-sanders
approved these changes
Sep 11, 2019
matthewrmshin
approved these changes
Sep 11, 2019
hjoliver
approved these changes
Sep 11, 2019
|
Thanks y'all! Once the Tree Component is merged, I will submit a new PR to address progress in the icons for the tree view 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with
generateand mock data was in my environment (see #192 and thanks @matthewrmshin !). Once fixed, managed to re-run the script usingmasterfrom both Cylc UI Server and Cylc Flow, and update the mock data.Also updated
Tree.vue's GraphQL query, and tested with offline mode, and with real data.Part of #145 , just submitting before as it will take a bit more to finish that component's PR, and it will make it easier reviewing the PR.
Also closes #191
Cheers
Bruno