Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View toolbar: tests #1149

Merged
merged 4 commits into from
Dec 1, 2022
Merged

View toolbar: tests #1149

merged 4 commits into from
Dec 1, 2022

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Nov 24, 2022 •
edited
Loading

Follow on from #1108
Built on #1108

  • Add component tests for the view toolbar.
  • Enable component tests in CI.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@oliver-sanders oliver-sanders self-assigned this Nov 24, 2022
@oliver-sanders oliver-sanders force-pushed the view-toolbar-tests branch 3 times, most recently from 12e10a2 to 8865b08 Compare November 30, 2022 11:06
@oliver-sanders oliver-sanders added this to the 1.4.0 milestone Nov 30, 2022
@oliver-sanders oliver-sanders marked this pull request as ready for review November 30, 2022 12:47
datamel
datamel approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

cypress/component/viewToolbar.cy.js Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
oliver-sanders
oliver-sanders commented Dec 1, 2022
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
wxtim
wxtim approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxtim wxtim merged commit f3404cf into cylc:master Dec 1, 2022
@oliver-sanders oliver-sanders deleted the view-toolbar-tests branch December 1, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamel datamel datamel approved these changes

@wxtim wxtim wxtim approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @wxtim @datamel