Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View toolbar #471

Open
4 tasks done
oliver-sanders opened this issue Jul 9, 2020 · 7 comments
Open
4 tasks done

View toolbar #471

oliver-sanders opened this issue Jul 9, 2020 · 7 comments
Labels
design UX/UI User experience and interface improvements
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jul 9, 2020

Work out what to do with the "view" controls.

Context

There is a very important feature which appeared in the early-2019 design outline which quietly disappeared in subsequent design documents.

The "view" toolbar circa early 2019-design outline:

old-toolbar

The UI as of July 2020:

Screenshot 2020-07-09 at 15 41 04

The initial idea had been to avoid the clutter of the Cylc7 toolbar by implementing something less obtrusive, however, the wonderful Lumino tabs have since superseded that more primitive layout model. Now we need to put them somewhere else.

Functionality

The toolbar should provide quick access to regularly used options (e.g. group and ungroup).

The main options expected are:

  • Group / Ungroup.
  • Filtering (e.g. by task state).
  • Visual Filtering (e.g. by reflow).
  • Window (e.g. n=1).
  • Transpose (for graphical layouts).
  • Subgraph (i.e. group by cycle point - for graphical layouts).
  • Freeze (for all layouts?).
  • Search (e.g. by task name).
  • Selection sharing (i.e. open the selection of one view in another).

Ideas

Sadly I think a toolbar is inevitable but we can minimise its visual intrusion on the UI. Thus far this is the best I've come up with:

toolbar

For mobile we will have to replace the toolbar with a burger bar, perhaps providing limited functionality.

Questions

[edit 2022] attempted to resolve open questions

  • Any better ideas?
    • None suggested.
  • Should all tab-related settings be in this toolbar (e.g. the graph view layout options)?
    • No objections registered, suggest that it should.
  • Should we hide the toolbar and have it display when the burger bar is clicked?
    • Food for future work/discussion, not a decision we need to make now.
  • Should we only display a limited set of icons and expand to the full set when an ellipses icon is clicked?
    • Given how long the task state filter component is I think we may need to do this or something similar.
@oliver-sanders oliver-sanders added question Flag this as a question for the next Cylc project meeting. design labels Jul 9, 2020
@oliver-sanders oliver-sanders added this to the 1.0 milestone Jul 9, 2020
@hjoliver
Copy link
Member

I've not had time to think about this in any great depth, but at first glance I like your suggestions above as they are.

@hjoliver
Copy link
Member

(Something for @kinow post infinite tree 😁 )

@oliver-sanders
Copy link
Member Author

The search and filter icons would need to toggle the search and filter inputs.

Perhaps these could appear in the row below?

@kinow
Copy link
Member

kinow commented Jan 20, 2021

I liked the location of the toolbar (would be under the lumino tab I think), and also the translucent icons changing colors. Might be easy to prototype it later (probably after 0.3 is out). Thanks!

@hjoliver
Copy link
Member

hjoliver commented Nov 8, 2021

(Needs to be pinned to the view so it doesn't scroll off the top).

@oliver-sanders
Copy link
Member Author

Note from #56

Try to centralise as much of the common functionality as possible, namely the user interfaces (i.e. sorting, filtering, etc) to avoid needing to re-implement these separately in each view.

@oliver-sanders oliver-sanders modified the milestones: 2.0.0, Pending Jun 8, 2022
@oliver-sanders oliver-sanders added UX/UI User experience and interface improvements and removed question Flag this as a question for the next Cylc project meeting. labels Oct 17, 2022
@oliver-sanders
Copy link
Member Author

#1108 introduces a toolbar for the graph view:

Screenshot 2022-11-02 at 14 15 07

This is implemented as a reusable component so can be shared by other views.

Suggest also using this component in the UserProfile for configuring the default view settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design UX/UI User experience and interface improvements
Projects
None yet
Development

No branches or pull requests

3 participants