Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

views: collect view options and make them configurable #1146

Open
oliver-sanders opened this issue Nov 24, 2022 · 0 comments
Open

views: collect view options and make them configurable #1146

oliver-sanders opened this issue Nov 24, 2022 · 0 comments
Milestone
Pending

Comments

@oliver-sanders
Copy link
Member

See also: #662 (comment) and #1108 (comment)

Each view has some options associated with it, e.g. the graph view has a "transpose" option and the tree/table views have a "cycle point sort order" option (currently configured globally but should probably be separate).

#471 (view toolbar) will provide a standard way for these options to be presented to the user. We should also collect the defaults for these options so that they can be provided to the view in a standard way.

This issue is about:

  • Collecting the default options for each component and allowing them to be provided to the view via a standard prop.
  • Making these defaults configurable from the settings page, ideally using the same view toolbar component.

Pull requests welcome!
@oliver-sanders oliver-sanders added this to the 1.x milestone Nov 24, 2022
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Feb 20, 2023
@oliver-sanders
options mixin: add a pattern for setting options on views
88062f5 
* Addresses cylc#1146
* Collects the view options so that they are contained in a single
  object. This allows us to easily save these options e.g. in browser
  storage.
* Defines a pattern for initiating views using specified options.
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Feb 20, 2023
@oliver-sanders
options mixin: add a pattern for setting options on views
5d48f75 
* Addresses cylc#1146
* Collects the view options so that they are contained in a single
  object. This allows us to easily save these options e.g. in browser
  storage.
* Defines a pattern for initiating views using specified options.
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Feb 20, 2023
@oliver-sanders
options mixin: add a pattern for setting options on views
18d83c1 
* Addresses cylc#1146
* Collects the view options so that they are contained in a single
  object. This allows us to easily save these options e.g. in browser
  storage.
* Defines a pattern for initiating views using specified options.
@oliver-sanders oliver-sanders mentioned this issue Feb 20, 2023
Closed
6 tasks
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Feb 21, 2023
@oliver-sanders
options mixin: add a pattern for setting options on views
f6af7f0 
* Addresses cylc#1146
* Collects the view options so that they are contained in a single
  object. This allows us to easily save these options e.g. in browser
  storage.
* Defines a pattern for initiating views using specified options.
@oliver-sanders oliver-sanders modified the milestones: 2.x, Pending Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pending
Development

No branches or pull requests
1 participant
@oliver-sanders