Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: 1.4.0 #327

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Prepare release: 1.4.0 #327

merged 4 commits into from
Jun 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 18, 2024

⚡ Merging this PR will automatically create a GitHub Release & publish the package ⚡

This PR was created by the Release stage 1 - create release PR workflow, triggered by @oliver-sanders

Tests:

  • Tests last run on master:
    tests.yml
  • ✔️ Build check passed - see the workflow run (number 39) for more info

Checklist:

  • Milestone complete?
    0 other open issues/PRs on milestone 1.4.0 at time of PR creation
  • Changelog up-to-date?
    • Examine pull requests made since the last release
    • "Released on" date updated? ✔️ 2024-06-18

Next steps:

  • @oliver-sanders should request 1 or 2 reviews
  • If any further changes are needed, push to this PR branch
  • After merging, the bot will comment below with a link to the release (if not, look at the PR checks tab)

Important

Do not use [skip ci] in commit messages pushed to this PR, as it will prevent the 2nd stage release workflow from running.

Workflow: Release stage 1 - create release PR, run: 39
@github-actions github-actions bot added this to the 1.4.0 milestone Jun 18, 2024
@github-actions github-actions bot added the release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish. label Jun 18, 2024
@wxtim
Copy link
Member

wxtim commented Jun 18, 2024

I think that #319 has a fix synced over to master, and probably ought to be logged: If you agree I'll prep a PR to this PR?

@MetRonnie
Copy link
Member

Does anyone know what is going on with the test failure?

@oliver-sanders
Copy link
Member

MB, I ran the pre-release tests before Ben's PR was merged so missed this change.

@MetRonnie MetRonnie merged commit 70bc52e into master Jun 18, 2024
9 checks passed
@MetRonnie MetRonnie deleted the prepare-1.4.0 branch June 18, 2024 16:34
Copy link
Contributor Author

✔️ success

Next steps for @oliver-sanders:


Comment created by workflow: Release stage 2 - auto publish, run: 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants