Repopulate cached GlobalConfig object if CYLC_SYMLINKS exported to env. #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
feat.reload_glbl_cfg_after_export_CYLC_SYMLINKS
branch
2 times, most recently
from
4a34384
to
81dec2c
Compare
MetRonnie
reviewed
Dec 4, 2023
|
~🚧 🏗️ 🚧 ~ Now only failing the same as master |
wxtim
force-pushed
the
feat.reload_glbl_cfg_after_export_CYLC_SYMLINKS
branch
2 times, most recently
from
5d4e8ed
to
0cc308d
Compare
is reloaded after the export of `CYLC_SYMLINKS` variable. This means that using the `CYLC_SYMLINKS` variable allows users to specify installation symlink locations in the `rose-suite.conf`.
wxtim
force-pushed
the
feat.reload_glbl_cfg_after_export_CYLC_SYMLINKS
branch
from
0cc308d
to
fa3611b
Compare
Added module version of gen workflow name fixture. Fix refs to runN or run1.
wxtim
force-pushed
the
feat.reload_glbl_cfg_after_export_CYLC_SYMLINKS
branch
from
3bc9b27
to
6ff23bf
Compare
|
Now failing identically to master nightly tests. |
Co-authored-by: Oliver Sanders <[email protected]> Update tests/functional/test_utils.py Co-authored-by: Oliver Sanders <[email protected]> fix tests
wxtim
force-pushed
the
feat.reload_glbl_cfg_after_export_CYLC_SYMLINKS
branch
from
421782e
to
6bb14bb
Compare
MetRonnie
reviewed
Jan 15, 2024
Co-authored-by: Ronnie Dutta <[email protected]>
…hub.com:wxtim/cylc-rose into feat.reload_glbl_cfg_after_export_CYLC_SYMLINKS * 'feat.reload_glbl_cfg_after_export_CYLC_SYMLINKS' of github.com:wxtim/cylc-rose: Apply suggestions from code review
|
@MetRonnie - this is failing in the same way as master - I'm working on fixing in #289, but I don't think that this PR needs to away that one for review. |
MetRonnie
approved these changes
Feb 6, 2024
| # the global config so that the value of this vars | ||
| # can be used by Jinja2 in the global config. | ||
| # https://github.com/cylc/cylc-rose/issues/237 | ||
| if environment: |
There was a problem hiding this comment.
Note, the environment is always populated as a result of automatic Rose variables.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237
This is now ready for review but needs testing against cylc/cylc-flow#5839.
Ensure that the cached globalconfig object is reloaded after the export of
CYLC_SYMLINKSvariable. This means that using theCYLC_SYMLINKSvariable allows users to specify installation symlink locations in therose-suite.conf.n.b. I was surprised to find that running
glbl_cfg()._DEFAULT = Nonedid not clear the cached config in a way that would force the reload in Cylc, but I think just reloading the config in Cylc Rose makes at least as much sense.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.