Skip to content

Commit

Permalink
feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
oliver-sanders committed Nov 8, 2023
1 parent b993900 commit 8169941
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
9 changes: 0 additions & 9 deletions cylc/rose/entry_points.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,6 @@

def pre_configure(srcdir: Path, opts: 'Values') -> dict:
"""Run before the Cylc configuration is read."""
if not srcdir:
# not sure how this could happen
return {
# default return value
'env': {},
'template_variables': {},
'templating_detected': None
}

# load the Rose config
config_tree = load_rose_config(Path(srcdir), opts=opts)

Expand Down
9 changes: 1 addition & 8 deletions cylc/rose/fileinstall.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,7 @@ def rose_fileinstall(
rundir: 'Path',
opts: 'Values',
) -> 'Union[ConfigNode, bool]':
"""Call Rose Fileinstall.
Args:
srcdir(pathlib.Path):
Search for a ``rose-suite.conf`` file in this location.
rundir (pathlib.Path)
"""
"""Call Rose Fileinstall."""
if not rose_config_exists(rundir):
return False

Check warning on line 36 in cylc/rose/fileinstall.py

View check run for this annotation

Codecov / codecov/patch

cylc/rose/fileinstall.py#L36

Added line #L36 was not covered by tests

Expand Down

0 comments on commit 8169941

Please sign in to comment.