Apply suggestions from code review

Co-authored-by: Ronnie Dutta <[email protected]>
cylc · Oct 2, 2023 · 24d5024 · 24d5024
1 parent 168abec
commit 24d5024
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cylc/rose/utilities.py b/cylc/rose/utilities.py
@@ -193,14 +193,14 @@ def identify_templating_section(config_node):
             f"You defined:\n\t{'; '.join(defined_sections)}"
         )
     elif defined_sections:
-        return id_templating_section(list(defined_sections)[0])
+        return id_templating_section(defined_sections.pop())
     else:
         return id_templating_section('')
 
 
 def id_templating_section(
     section: Optional[str] = None,
-    with_brackets: Optional[bool] = False
+    with_brackets: bool = False
 ) -> str:
     """Return a full template section string."""
     templating = None

diff --git a/tests/unit/test_config_node.py b/tests/unit/test_config_node.py
@@ -258,6 +258,7 @@ def test_identify_templating_section(node_, expect, raises):
     (
         ([None], 'template variables'),
         (['jinja2'], 'jinja2:suite.rc'),
+        (['jinja2:suite.rc'], 'jinja2:suite.rc'),
         ([None, True], '[template variables]'),
         (['jinja2', True], '[jinja2:suite.rc]'),
     )