Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data store: dont update outputs incrementally #6403

Merged

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Oct 11, 2024

An awkward bodge to work around #6307

I'm not sure we want to go ahead with this, at least not in the long term, however, it should be enough to unblock (at lest the review of) cylc/cylc-ui#1886

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Internal protocol issue, no changelog required
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie

This comment was marked as resolved.

@oliver-sanders oliver-sanders force-pushed the dont-update-outputs-incrementally branch from 591632f to a23100c Compare October 11, 2024 11:53
@oliver-sanders

This comment was marked as resolved.

@oliver-sanders oliver-sanders force-pushed the dont-update-outputs-incrementally branch from a23100c to b62885b Compare October 29, 2024 13:27
* We don't have a protocol for updating arbitrary lists incrementally.
* See cylc#6307
* This is a temporary patch to disable incremental output updates until
  we have a suitable protocol for doing so.
@oliver-sanders oliver-sanders force-pushed the dont-update-outputs-incrementally branch from b62885b to c6a3e61 Compare October 29, 2024 13:29
@oliver-sanders oliver-sanders self-assigned this Oct 29, 2024
@oliver-sanders oliver-sanders added this to the 8.4.0 milestone Oct 29, 2024
@oliver-sanders
Copy link
Member Author

Short of a universal solution to #6307, this patch seems a reasonable way to get the info view in the UI off of the ground.

@oliver-sanders oliver-sanders marked this pull request as ready for review October 29, 2024 13:32
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dwsutherland dwsutherland merged commit 5bfb487 into cylc:master Oct 30, 2024
27 checks passed
@oliver-sanders oliver-sanders deleted the dont-update-outputs-incrementally branch October 30, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants