Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

messages: enforce unique task messages #6235

Merged
merged 1 commit into from
Jul 18, 2024
Merged

messages: enforce unique task messages #6235

merged 1 commit into from
Jul 18, 2024

Conversation

oliver-sanders
Copy link
Member

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included (very minor, unreported, we may want to omit this)
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.3.3 milestone Jul 15, 2024
@oliver-sanders oliver-sanders self-assigned this Jul 15, 2024
hjoliver
hjoliver approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what codecov is thinking there 🤔

@markgrahamdawson markgrahamdawson merged commit 52d523d into cylc:8.3.x Jul 18, 2024
26 of 27 checks passed
@oliver-sanders oliver-sanders deleted the 6056 branch July 18, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgrahamdawson markgrahamdawson markgrahamdawson approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
small
Projects
None yet
Milestone
8.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @hjoliver @markgrahamdawson