Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: exclude urwid versions that break Tui #5992

Merged
merged 1 commit into from
Feb 22, 2024
Merged

setup: exclude urwid versions that break Tui #5992

merged 1 commit into from
Feb 22, 2024

Conversation

oliver-sanders
Copy link
Member

Closes #5985

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
setup: exclude urwid versions that break Tui
e5023e8 
* A small issue in two urwid releases caused Tui to crash on startup.
@oliver-sanders oliver-sanders added this to the cylc-8.2.5 milestone Feb 22, 2024
@oliver-sanders oliver-sanders self-assigned this Feb 22, 2024
@oliver-sanders oliver-sanders mentioned this pull request Feb 22, 2024
Merged
16 tasks
@oliver-sanders oliver-sanders marked this pull request as ready for review February 22, 2024 11:49
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Feb 22, 2024
@MetRonnie MetRonnie added non-cylc bug This is a bug, but not in Cylc small bug Something is wrong :( and removed bug Something is wrong :( labels Feb 22, 2024
@MetRonnie MetRonnie merged commit 90356cc into cylc:8.2.x Feb 22, 2024
37 checks passed
@MetRonnie MetRonnie linked an issue Feb 22, 2024 that may be closed by this pull request
tui: broken with new urwid versions #5985
Closed
@oliver-sanders oliver-sanders deleted the tui-exclude-problem-urwid-releases branch February 22, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@wxtim wxtim Awaiting requested review from wxtim

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :( dependencies non-cylc bug This is a bug, but not in Cylc small
Projects
None yet
Milestone
cylc-8.2.5
Development

Successfully merging this pull request may close these issues.

tui: broken with new urwid versions
2 participants
@oliver-sanders @MetRonnie