-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite doctest as unit test #5818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the most suitable doctest, but I don't get the motive for translating it?
To avoid the hacky patching of |
Ah, hadn't spotted the attached issue, sorry, must read better. |
Blocked by copilot approval? |
No, as mentioned on Teams the guidance wasn't clear that Copilot has been approved for this trial. Anyway, if I was going to manually convert this test the code would have been 100% identical... |
(Added blocked label pending approval at your end). |
This comment was marked as resolved.
This comment was marked as resolved.
Ok, Oliver wants to take this PR as an opportunity to have the generative AI guidance at our end improved as it's still a bit unworkable in its current draft |
Unblocked |
Closes #4413
This rewrite was handled by GitHub Copilot
Check List
CONTRIBUTING.md
and added my name as a Code Contributor. (But GitHub Copilot has not added themselves...)?.?.x
branch.