Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.12 #5794

Merged
merged 12 commits into from
Nov 13, 2023
Merged

Support Python 3.12 #5794

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
665bf9f
add generic Python 3 (i.e. A bleeding edge version) to tests
wxtim Oct 27, 2023
04ad456
remove report timings from Python 3.12
wxtim Oct 27, 2023
ad511e4
fix flake8 issues
wxtim Oct 27, 2023
85449a4
Response to review
wxtim Oct 30, 2023
4b595d2
remove possibly unwanted flake8 fix
wxtim Oct 30, 2023
e9d035f
Update cylc/flow/scripts/report_timings.py
wxtim Oct 30, 2023
3183cab
Commented out broken test lines (see issue 5812)
wxtim Nov 3, 2023
8636bf3
replace smtpd with aiosmtpd in the test_header file
wxtim Nov 6, 2023
6d7509e
fix tests
wxtim Nov 7, 2023
bdb53be
Merge branch 'add_generic_python_3_to_tests' of github.com:wxtim/cylc…
wxtim Nov 7, 2023
b7de310
Undo some over-zealous changes to tests.
wxtim Nov 7, 2023
bbe0d79
Update tests/functional/events/29-task-event-mail-1.t
wxtim Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_fast.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fail-fast: false # Don't let a failed MacOS run stop the Ubuntu runs
matrix:
os: ['ubuntu-latest']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3']
include:
- os: 'macos-latest'
python-version: '3.7'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test_functional.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ jobs:
# NOTE: includes must define ALL of the matrix values
include:
# latest python
- name: 'py-3.11'
- name: 'py-3-latest'
os: 'ubuntu-latest'
python-version: '3.11'
python-version: '3'
test-base: 'tests/f'
chunk: '1/4'
platform: '_local_background*'
Expand Down
10 changes: 9 additions & 1 deletion cylc/flow/scripts/report_timings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,18 @@ def write_category(self, buf, category, df_reshape, df_describe):
pass

def _check_imports(self):
if sys.version_info > (3, 11):
raise CylcError(
'Cylc Report Timings is deprecated: It is incompatible'
wxtim marked this conversation as resolved.
Show resolved Hide resolved
' with Python > 3.11'
)
try:
import pandas
except ImportError:
raise CylcError('Cannot import pandas - summary unavailable.')
raise CylcError(
'Cannot import pandas - summary unavailable.'
' try: pip install cylc-flow[report-timings]'
)
else:
del pandas

Expand Down
1 change: 0 additions & 1 deletion setup.cfg
View file
Open in desktop
wxtim marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ all =
%(main_loop-log_db)s
%(main_loop-log_main_loop)s
%(main_loop-log_memory)s
%(report-timings)s
%(tests)s
%(tutorials)s

Expand Down
Loading