Review suggestions

Co-authored-by: Ronnie Dutta <[email protected]>
cylc · Oct 31, 2024 · a78b95d · a78b95d
1 parent a67855a
commit a78b95d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/cylc/flow/prerequisite.py b/cylc/flow/prerequisite.py
@@ -264,7 +264,7 @@ def _eval_satisfied(self) -> bool:
 
     def satisfy_me(
         self, outputs: Iterable['Tokens'],
-        mode: "Optional[Union[RunMode, str]]" = RunMode.LIVE
+        mode: Optional[RunMode] = RunMode.LIVE
     ) -> 'Set[Tokens]':
         """Attempt to satisfy me with given outputs.
 

diff --git a/cylc/flow/task_pool.py b/cylc/flow/task_pool.py
@@ -1553,7 +1553,7 @@ def spawn_on_all_outputs(
                 if completed_only:
                     c_task.satisfy_me(
                         [itask.tokens.duplicate(task_sel=message)],
-                        mode=itask.run_mode   # type: ignore
+                        mode=itask.run_mode
                     )
                     self.data_store_mgr.delta_task_prerequisite(c_task)
                 self.add_to_pool(c_task)

diff --git a/cylc/flow/task_proxy.py b/cylc/flow/task_proxy.py
@@ -550,7 +550,9 @@ def state_reset(
         return False
 
     def satisfy_me(
-        self, task_messages: 'Iterable[Tokens]', mode: "RunMode" = RunMode.LIVE
+        self,
+        task_messages: 'Iterable[Tokens]',
+        mode: Optional[RunMode] = RunMode.LIVE,
     ) -> 'Set[Tokens]':
         """Try to satisfy my prerequisites with given output messages.
 

diff --git a/cylc/flow/task_state.py b/cylc/flow/task_state.py
@@ -19,6 +19,7 @@
 from typing import (
     TYPE_CHECKING,
     Dict,
+    Optional,
     Iterable,
     List,
     Set,
@@ -325,7 +326,7 @@ def __call__(
     def satisfy_me(
         self,
         outputs: Iterable['Tokens'],
-        mode: "RunMode",
+        mode: "Optional[RunMode]",
     ) -> Set['Tokens']:
         """Try to satisfy my prerequisites with given outputs.