Skip to content

Commit

Permalink
Upgrade trigger warning to error.
Browse files Browse the repository at this point in the history
  • Loading branch information
hjoliver committed Oct 21, 2024
1 parent 85ca1d0 commit 21cb3c3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cylc/flow/task_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -1928,7 +1928,7 @@ def set_prereqs_and_outputs(
# Set existing task proxies.
for itask in itasks:
if flow == ['none'] and itask.flow_nums != set():
LOG.warning(
LOG.error(

Check warning on line 1931 in cylc/flow/task_pool.py

View check run for this annotation

Codecov / codecov/patch

cylc/flow/task_pool.py#L1931

Added line #L1931 was not covered by tests
f"[{itask}] ignoring 'flow=none' set: task already has"
f" {stringify_flow_nums(itask.flow_nums, full=True)}"
)
Expand Down Expand Up @@ -2176,13 +2176,13 @@ def force_trigger_tasks(
# Trigger active tasks.
for itask in existing_tasks:
if flow == ['none'] and itask.flow_nums != set():
LOG.warning(
LOG.error(

Check warning on line 2179 in cylc/flow/task_pool.py

View check run for this annotation

Codecov / codecov/patch

cylc/flow/task_pool.py#L2179

Added line #L2179 was not covered by tests
f"[{itask}] ignoring 'flow=none' trigger: task already has"
f" {stringify_flow_nums(itask.flow_nums, full=True)}"
)
continue

Check warning on line 2183 in cylc/flow/task_pool.py

View check run for this annotation

Codecov / codecov/patch

cylc/flow/task_pool.py#L2183

Added line #L2183 was not covered by tests
if itask.state(TASK_STATUS_PREPARING, *TASK_STATUSES_ACTIVE):
LOG.warning(f"[{itask}] ignoring trigger - already active")
LOG.error(f"[{itask}] ignoring trigger - already active")
continue
self.merge_flows(itask, flow_nums)
self._force_trigger(itask)
Expand Down

0 comments on commit 21cb3c3

Please sign in to comment.