Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodoc built-in xtrigger functions #673

Closed
wants to merge 1 commit into from

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Nov 22, 2023

The debug arg is not around anymore. By autofunction'ing, these will always be valid. The downside is pulling in the docstring is quite verbose...

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

@MetRonnie MetRonnie added this to the 8.2.x milestone Nov 22, 2023
@MetRonnie MetRonnie self-assigned this Nov 22, 2023
@oliver-sanders
Copy link
Member

Note, this PR will conflict with #671 which also auto-documents xtriggers, but in the plugins section (the xtriggers section is more appropriate).

We could probably do with pulling any relevant text out of cylc-doc and into the xtrigger docstrings to keep it all together?

For maintainability, I think we should probably go along the same lines at the job runner handlers and put the autosummary or autodoc directive in the cylc-flow code, then autodocument the init file, WDYT:

https://github.com/cylc/cylc-flow/blob/master/cylc/flow/job_runner_handlers/__init__.py

@MetRonnie MetRonnie marked this pull request as draft November 23, 2023 12:10
@oliver-sanders
Copy link
Member

Closes #106

@MetRonnie MetRonnie linked an issue Feb 1, 2024 that may be closed by this pull request
@MetRonnie
Copy link
Member Author

Superseded by #686

@MetRonnie MetRonnie closed this Feb 20, 2024
@MetRonnie MetRonnie deleted the xtriggers branch February 20, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document built-in xtriggers
2 participants