Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore command help reference section #237

Closed
wants to merge 1 commit into from

Conversation

hjoliver
Copy link
Member

As far as I recall we didn't decided to ditch the CLI command help reference section of the User Guide??

Maybe we just disabled it when the generator script broke after removing the old command "categories" in the cylc-flow CLI.

If we want to restore it, it's an easy fix. Any strong opinions?

@hjoliver hjoliver self-assigned this Apr 13, 2021
@hjoliver
Copy link
Member Author

hjoliver commented Apr 13, 2021

Building the docs on this branch revealed cylc/cylc-flow#4171

@hjoliver
Copy link
Member Author

shot

@hjoliver hjoliver requested a review from MetRonnie April 13, 2021 02:40
@hjoliver hjoliver marked this pull request as draft April 13, 2021 02:40
END

for COM in $($CYLC commands); do
for COM in $(cylc help all | awk '{print $1}' | sort); do
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI build failed, I think because this line doesn't work if the terminal width is too low ?? (newlines get inserted into the help text)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have to be narrower than the longest command name to trip awk up?!

@MetRonnie MetRonnie linked an issue Apr 13, 2021 that may be closed by this pull request
@oliver-sanders
Copy link
Member

This was kinda purposefully removed pending conversion to argparse which would enable us to autodocument using standard tooling - #185

Of course we can keep the old CLI help for now though but be aware that all of the references will change when we change implementation.

@oliver-sanders oliver-sanders removed a link to an issue Apr 13, 2021
@hjoliver
Copy link
Member Author

Oh yeah. From that Issue, I guess this PR restores the option of final resort:

[last resort] the implementation of a crude autodocumenter (like we used to have).

Looking at the command ref section (or the image above) it probably is quite useful to have. All the command names are visible at once, and you can click on them to instantly see what they do (to state the obvious).

If the aim is to retain the command reference but generate it by more sophisticated means, then I think we should keep the old way until we have that. Users don't care about the implementation.

@oliver-sanders
Copy link
Member

Fair enough, we can put it back in for now with the caveat that anyone who links into this page has automatically volunteered to fix the references later 😈.

(the main reason I pulled it out before putting the new one in is because it took an age to run for each build).

@hjoliver
Copy link
Member Author

It is slow. On my box 12 secs. (Out of an 18 sec build time).

@MetRonnie MetRonnie added this to the 8.0.0 milestone Nov 15, 2021
@hjoliver hjoliver modified the milestones: 8.0rc1, 8.x Jan 27, 2022
@hjoliver
Copy link
Member Author

hjoliver commented Apr 2, 2023

Closing, there's no great need for this.

@hjoliver hjoliver closed this Apr 2, 2023
@oliver-sanders oliver-sanders removed this from the pending milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants