aws/terraform: support for aws_db_instance #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlr-8
approved these changes
Dec 14, 2020
Comment on lines
+46
to
+60
| var dbTypeMap = map[string]dbType{ | ||
| "aurora": {"Aurora MySQL", ""}, | ||
| "aurora-mysql": {"Aurora MySQL", ""}, | ||
| "mariadb": {"MariaDB", ""}, | ||
| "mysql": {"MySQL", ""}, | ||
| "postgres": {"PostgreSQL", ""}, | ||
| "oracle-se": {"Oracle", "Standard"}, | ||
| "oracle-se1": {"Oracle", "Standard One"}, | ||
| "oracle-se2": {"Oracle", "Standard Two"}, | ||
| "oracle-ee": {"Oracle", "Enterprise"}, | ||
| "sqlserver-se": {"SQL Server", "Standard"}, | ||
| "sqlserver-ee": {"SQL Server", "Enterprise"}, | ||
| "sqlserver-ex": {"SQL Server", "Express"}, | ||
| "sqlserver-web": {"SQL Server", "Web"}, | ||
| } |
There was a problem hiding this comment.
Does this include all types or are we missing some? I'm asking just in case of documentation
Speaking of contribution, would it be good to have some "collaboration" documentation, like "how to add a new resource" type of thing?
There was a problem hiding this comment.
It includes all of the possible engines: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html (can't link to the relevant section directly, but the list is under "Engine")
Yeah, it'd be great to have a CONTRIBUTING file, as well as a good README. I'll start working on them once we have the library working internally and we're ready to go OSS. 👍 (Added it as a point of #10 for now.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
aws_db_instanceresource for both the ingesting and cost estimation.