Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Error when non-public entity property is set via proxy #502

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

roxblnfk
Copy link
Member

🔍 What was changed

Throw Error when non-public entity property is set via proxy

🤔 Why?

The ORM does not write a value to a private property, nor does it report this. Now, the proxy will throw an Error when writing to a non-public property, which is similar to the standard behavior of PHP objects.

Ref: #499

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (9703d14) to head (2cd6f7b).
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #502   +/-   ##
=========================================
  Coverage     91.59%   91.60%           
  Complexity     1814     1814           
=========================================
  Files           115      115           
  Lines          4642     4647    +5     
=========================================
+ Hits           4252     4257    +5     
  Misses          390      390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit d790848 into 2.x Dec 12, 2024
27 of 28 checks passed
@roxblnfk roxblnfk deleted the private-fields branch December 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants